Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/web/general integration #394

Merged
merged 96 commits into from
Sep 26, 2024
Merged

Conversation

Tinashe-Austin
Copy link
Contributor

@Tinashe-Austin Tinashe-Austin commented Sep 25, 2024

Description

General fixes plus some new components

Fixes #323 #322 #280

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Tinashe-Austin Tinashe-Austin added type: chore Just a cleanup or minor update type: feature A new feature type: fix Introduces a fix for a previous issue type: testing This affects one or more tests For: frontend This is mainly related to frontend UI code priority: high This needs/needed to be addressed as soon as possible effort: 13 This may require a month/required of work or multiple platform: web/desktop This is related to web/desktop platforms For: integration This is for work involving integration with the backend/model API labels Sep 25, 2024
@Tinashe-Austin Tinashe-Austin self-assigned this Sep 25, 2024
Copy link

gitguardian bot commented Sep 25, 2024

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
13149987 Triggered Generic Password d4d362f frontend/occupi-mobile4/services/authservices.ts View secret
13149987 Triggered Generic Password 5a0e6d8 frontend/occupi-mobile4/services/authservices.ts View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 3.26797% with 148 lines in your changes missing coverage. Please review.

Project coverage is 44.33%. Comparing base (ae87bbd) to head (9404292).
Report is 105 commits behind head on develop.

Files with missing lines Patch % Lines
...ntend/occupi-web/src/assets/icons/UploadButton.tsx 0.90% 110 Missing ⚠️
frontend/occupi-web/src/assets/icons/Bar.tsx 9.52% 19 Missing ⚠️
frontend/occupi-web/src/assets/icons/Worker.tsx 9.52% 19 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (ae87bbd) and HEAD (9404292). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (ae87bbd) HEAD (9404292)
3 1
Additional details and impacted files
@@             Coverage Diff              @@
##           develop     #394       +/-   ##
============================================
- Coverage    69.14%   44.33%   -24.81%     
============================================
  Files           56       17       -39     
  Lines         6329      397     -5932     
  Branches        84        0       -84     
============================================
- Hits          4376      176     -4200     
+ Misses        1893      221     -1672     
+ Partials        60        0       -60     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tinashe-Austin Tinashe-Austin merged commit 6c90a19 into develop Sep 26, 2024
5 of 7 checks passed
@waveyboym waveyboym deleted the fix/web/General-Integration branch September 26, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: 13 This may require a month/required of work or multiple For: frontend This is mainly related to frontend UI code For: integration This is for work involving integration with the backend/model API platform: web/desktop This is related to web/desktop platforms priority: high This needs/needed to be addressed as soon as possible type: chore Just a cleanup or minor update type: feature A new feature type: fix Introduces a fix for a previous issue type: testing This affects one or more tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK] Frontend Heat Map Diagram for web
2 participants